Add CachingLocator. #14020
Merged
Add CachingLocator. #14020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
390f221 to
48445b7
Compare
kimadeline
reviewed
Sep 22, 2020
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
48445b7 to
85b2b6b
Compare
4 tasks
10 tasks
karrtikr
reviewed
Sep 23, 2020
karrtikr
reviewed
Sep 24, 2020
karrtikr
reviewed
Sep 24, 2020
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
85b2b6b to
e41ccef
Compare
Codecov Report
@@ Coverage Diff @@
## main #14020 +/- ##
==========================================
+ Coverage 59.96% 60.04% +0.07%
==========================================
Files 706 710 +4
Lines 39180 39420 +240
Branches 5681 5708 +27
==========================================
+ Hits 23494 23668 +174
- Misses 14449 14501 +52
- Partials 1237 1251 +14
Continue to review full report at Codecov.
|
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
e41ccef to
5fabd2a
Compare
|
@kimadeline and @karrtikr, I should have left this as a draft PR. I'll let you know when I've wrapped up the last few changes I have to make. |
10 tasks
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
5fabd2a to
0d8f49d
Compare
|
@kimadeline, @karrtikr, the PR is ready to go now. |
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
0d8f49d to
9e97735
Compare
kimadeline
suggested changes
Oct 1, 2020
src/client/pythonEnvironments/base/locators/composite/cachingLocator.ts
Outdated
Show resolved
Hide resolved
src/client/pythonEnvironments/base/locators/composite/cachingLocator.ts
Outdated
Show resolved
Hide resolved
src/client/pythonEnvironments/base/locators/composite/cachingLocator.ts
Outdated
Show resolved
Hide resolved
src/client/pythonEnvironments/base/locators/composite/cachingLocator.ts
Outdated
Show resolved
Hide resolved
src/client/pythonEnvironments/base/locators/composite/cachingLocator.ts
Outdated
Show resolved
Hide resolved
src/client/pythonEnvironments/base/locators/composite/cachingLocator.ts
Outdated
Show resolved
Hide resolved
|
Since Kartik is out, you may want to request a review from @karthiknadig, because I don't want to shoulder the responsibility of reviewing this PR alone 😆 |
|
@ericsnowcurrently @kimadeline I just had one comment regarding potential correctness #14020 (comment) I leave the rest upto you guys😄 |
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
9e97735 to
4cc412e
Compare
ericsnowcurrently
force-pushed
the
pyenvs-component-caching-locator
branch
from
abf86c3 to
e8914f6
Compare
|
Will re-review this afternoon. |
kimadeline
approved these changes
Oct 7, 2020
karthiknadig
approved these changes
Oct 7, 2020
|
resetting "checks" trigger |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #14020 +/- ##
==========================================
- Coverage 59.91% 59.91% -0.01%
==========================================
Files 709 712 +3
Lines 39334 39520 +186
Branches 5698 5722 +24
==========================================
+ Hits 23567 23678 +111
- Misses 14529 14586 +57
- Partials 1238 1256 +18
Continue to review full report at Codecov.
|
luabud
pushed a commit
to luabud/vscode-python
that referenced
this pull request
Oct 26, 2020
Note that we factored out the BackgroundRequestLooper class to keep CachingLocator focused, especially as it was important to deal with one "refresh" at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I factored out the
BackgroundRequestLooperclass to keepCachingLocatorfocused, especially as I found it was important to deal with one "refresh" at a time.[ ] Has a news entry file (remember to thank yourself!).[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.